Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registered image selector fixes #64

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Registered image selector fixes #64

merged 4 commits into from
Jul 8, 2021

Conversation

yoda-vid
Copy link
Collaborator

@yoda-vid yoda-vid commented Jul 7, 2021

This PR makes several fixes/updates to the "Registered Images" selectors in the GUI:

…tiple extensions

Use the other library function that supports known multiple extensions as advertised.
Use the library function that finds suffixes with multiple extensions when deconstructing filenames so that registered image files in formats such as `.nii.gz` are identified.
Commit f05fb8b made registered image extensions visible to identify the extension matching an existing file. Hide these extensions while keeping a reference to them in a dictionary. Use the library extension splitter to support filenames with multiple extensions.
Commit 93f0ffc introduced a regression where loading a new image in the GUI after loading an image with an "atlas" registered suffix prevented the new image from being loaded. Add a flag to reset the registered suffixes when loading a new image through the GUI. Integrate this and the ignore filename flag into the filename setter and use this function instead of setting the filename variable directly.
@yoda-vid yoda-vid added the bug Something isn't working label Jul 7, 2021
@yoda-vid yoda-vid merged commit 1fb5ed7 into master Jul 8, 2021
@yoda-vid yoda-vid deleted the fix_reg_img_selectors branch July 8, 2021 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registered image paths with multiple extensions are not identified
1 participant